-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Fix: Unknown media obeys settings.mediaLoadErrorHandling #4461
base: master
Are you sure you want to change the base?
Fix: Unknown media obeys settings.mediaLoadErrorHandling #4461
Conversation
👍 for this cc: @ashkulz |
Any update on this @ashkulz? |
Sorry, I didn't notice this at all. Will review it by this weekend 🙈 |
@ashkulz Bump on this? |
Bumping again. Hoping to get this merged in as we've hit it in our app as well. Our workaround is to try to detect this specific case by looking for an error code of 1 and detecting the |
i'm thinking of doing the same as what mikesnare did. but there may be other legitimate conditions where the UnknownContentError or ContentOperationNotPermittedError or some other errors that may occur. so, i hope this pr gets merged and a new release with the binaries released as well. for now, i forked and applied the patch. but building it from source takes a very long time. in addition, i am only able to build it for my particular environment for now. |
Any update? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late review! The problem is, the only way wkhtmltopdf can know it's a media request is by looking at the file extension -- but the PR as-is changes the non-media error handling, so is incorrect.
Co-authored-by: Ashish Kulkarni <ashish@kulkarni.dev>
@ashkulz Thanks for the suggestion. I've updated the PR. |
No description provided.